Fix AOF rewrite and restore BF tests #75
Open
+35
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AOF rewrite tests were failing because bloom filter data was not being properly restored after server restart. The root cause was twofold: 1. BF.LOAD command was replicating during AOF loading, causing duplicate entries 2. Tests were not properly configuring AOF persistence for server restart Changes: - Modified BF.LOAD handler to skip replication when loading from AOF by checking must_obey_client() context - Updated AOF tests to enable appendonly before adding data - Added wait for initial AOF rewrite to prevent concurrent rewrites - Set appendonly in server startup args for proper AOF loading on restart Also includes minor fixes: - Changed build.sh shebang to bash for better compatibility - Updated pytest requirement to 7.4.3 - Fixed indentation in utils.rs documentation Fixes valkey-io#74
zackcam
reviewed
Oct 14, 2025
| // if filter not exists, create it. | ||
| let hex = value.to_vec(); | ||
| let validate_size_limit = !must_obey_client(ctx); | ||
| let is_aof_loading = must_obey_client(ctx); |
Contributor
There was a problem hiding this comment.
Do we need this intermediary step here of having the variable of is_aof_loading could we not use validate_size_limit on line 829?
Member
|
@arpitbbhayani can you fix the DCO? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AOF rewrite tests were failing because bloom filter data was not being properly restored after server restart. The root cause was twofold:
Changes:
Also includes minor fixes:
Fixes #74